Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview #6779

Merged
merged 8 commits into from
Mar 6, 2025
Merged

chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview #6779

merged 8 commits into from
Mar 6, 2025

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Mar 4, 2025 •
edited
Loading

Short description

This PR improves the a11y behavior from the payment method detail screen by adding a more detailed summary label when focusing on the payment method card.

List of changes proposed in this pull request

  • Wrapped the PayPalLogo component inside a View from the PaymentCard component to be accessible with a description;
  • Added the accessibilityRole to the view that wraps the payment card detail from the Payment method details;

How to test

  • With the SR enabled, navigate the payment method details screen and check that PayPal is announced correctly when focusing on the payment card and that Validity is announced correctly if the payment is a card.

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 4, 2025
@Hantex9 Hantex9 requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 4, 2025 10:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

PR Title Validation for conventional commit type

✅ All good! PR title follows the conventional commit type.

@Hantex9 Hantex9 changed the title chore: [IOBP-1243,IOBP-1244] a11y improvements on payment method details card preview chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.94%. Comparing base (dd76346) to head (f01add5).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6779   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files        1578     1578           
  Lines       32714    32714           
  Branches     7377     7377           
=======================================
  Hits        16665    16665           
- Misses      16002    16003    +1     
+ Partials       47       46    -1
Files with missing lines Coverage Δ
...eatures/payments/common/components/PaymentCard.tsx 96.87% <ø> (ø)
...nents/PaymentsMethodDetailsBaseScreenComponent.tsx 13.63% <ø> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd76346...f01add5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hantex9
Merge remote-tracking branch 'origin/IOBP-1243-a11y-payment-method-de…
75e4dc2 
…tails' into IOBP-1243-a11y-payment-method-details
@Hantex9
Copy link
Contributor Author

Hantex9 commented Mar 6, 2025

In Android, I was unable to focus on the validity label by swiping/tapping

Screen.Recording.2025-03-06.at.08.47.54.mov

Good catch! Since the heading of the card and its validity is just a summary of the content and not interactive elements, I solved by removing the focus on the text inside the card and adding a wrapper container that announce the text summary inside. 34f46b6

Preview

preview.webm

@Hantex9 Hantex9 requested a review from LeleDallas March 6, 2025 10:59
@Hantex9 Hantex9 enabled auto-merge March 6, 2025 12:17
@Hantex9 Hantex9 added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 3010dea Mar 6, 2025
22 checks passed
@Hantex9 Hantex9 deleted the IOBP-1243-a11y-payment-method-details branch March 6, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeleDallas LeleDallas LeleDallas approved these changes

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

Assignees
No one assigned
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hantex9 @LeleDallas